Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove python 3.8 for dbt 1.5 #10872

Merged
merged 1 commit into from
Oct 18, 2024
Merged

Remove python 3.8 for dbt 1.5 #10872

merged 1 commit into from
Oct 18, 2024
+19 −26

Conversation

peterallenwebb
Copy link
Contributor

@peterallenwebb peterallenwebb commented Oct 16, 2024 •
edited
Loading

Problem

Python 3.8 is EOL and no longer supported by some of dbt's upstream dependencies.

Solution

We are ending support for 3.8 in all future releases, and will no longer test against it.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@peterallenwebb peterallenwebb requested a review from a team as a code owner October 16, 2024 21:29
@cla-bot cla-bot bot added the cla:yes label Oct 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

1 similar comment
@github-actions GitHub Actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@gshank @peterallenwebb
Remove Python 3.8 from various places (#10861)
bb5f278 
* Remove Python 3.8 from various places

* Add changelog entry.

---------

Co-authored-by: Peter Allen Webb <[email protected]>
@gshank gshank changed the base branch from main to 1.5.latest October 16, 2024 22:17
@gshank gshank closed this Oct 16, 2024
@gshank gshank reopened this Oct 16, 2024
@peterallenwebb peterallenwebb changed the title Remove python 3.8 for 1.5 Remove python 3.8 for dbt 1.5 Oct 17, 2024
@peterallenwebb peterallenwebb merged commit d30c68e into 1.5.latest Oct 18, 2024
44 of 45 checks passed
@peterallenwebb peterallenwebb deleted the remove_python_3.8_for_1.5 branch October 18, 2024 21:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@graciegoheen graciegoheen graciegoheen approved these changes

@gshank gshank gshank approved these changes

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@peterallenwebb @gshank @graciegoheen